* update models with updated permission enum
* add suppress message attribute
* update integration tests
* refactor: new and legacy update teams endpint
* refactor: add new delete team endpoint
* use TeamPermission on NewTeam
* use updated delete on team context dispose
* add permission enum for team response object
* refactor: remove legacy suffix from method names
* introduce permissions object on Team
* refactor: rename enum to TeamRepositoryPermission
* fix formatting
* change Permission to string to match api specs
* add TeamRepository
* add CheckTeamPermission endpoint support
* fix convention tests
* update comments on TeamRepository props
* add two new endpoints in TeamsClient
* refactor: rename ApiUrl for TeamPermission
* fix test
* implement methods for new endpoints
* add the integration tests
* fix spelling
* update comments
* refactor: rename method name
* fix: add end tag for remarks
* refactor: remove unused method param
* fix docstring comment
* the unit tests are in finally
* add docs for teams api
* split CheckTeamPermissions into two methods
* Update ObservableTeamsClientTests.cs based on review
Co-authored-by: Keegan Campbell <me@kfcampbell.com>
* add cref to legacy update and delete endpoints
* remove editorconfig file
* Update Octokit.Tests/Clients/TeamsClientTests.cs
Co-authored-by: Keegan Campbell <me@kfcampbell.com>
* remove unused line
* rename variable based on review
* rename prop to match constructor param
* add comment to explain TeamPermission enum values on update
Co-authored-by: notauserx <notauserx@users.noreply.github.com>
Co-authored-by: Keegan Campbell <me@kfcampbell.com>
* Fix API URLs for GHES
Fix leading slashes causing API calls to fail when used with GitHub Enterprise.
* Fix tests
Fix tests that should have been updated in the previous commit.
Co-authored-by: Keegan Campbell <me@kfcampbell.com>
* created the interface and models for the repository secrets client
* created a repository actions client to sit between repository and secrets for future extensibility
* created the repository secret client and supporting objects to enable data transfer
* created object for create or update secret body and made fixes to pass unit tests
* created repository action unit tests
* created unit tests for RepositorySecretsClient
* removed set from secrets interface
* fixed docs and added observable actions client
* added Actions to repository client
* created IObservable repository secrets client
* fixed property in wrong interface
fixed wrong Ctor unit test
* created repository decrets reactive tests and clients
* created organization actions and scerets classes and made them available through the oprganizations client
* fixed intellisense text
* removed uneeded getall call after return type change
* created organization secret client and classes to support it
* created the observable org secrets client and fixed a typo in a method name
* added more ensure checks
* removed unused xml doc setting
* created the unit tests for the organization secrets client
fixed broken unit test for repository secrets client
* created observable organization actions and secrets client unit tests
* added sodium.core to the integration tests to test secret creation
* fixed keyid type
* added actions client integration test classes (empty since the class currently doesn't have any native methods)
* fixed deserialization issue
* changed property name for deserialization issues
* added doc for repoid on orginzation secrets url generator
* created integration tests for repository and organization secrets
* changed how return occurs for setting list of repos for secret
* fixed some names and removed reset org name
* created integration tests for observable org secrets client
* removed default org value
* created the integration tests for the observable repository secrets client
* removed default owner project value
* fixed unit tests
* Update links to new docs site
* Update doc links to new docs site
* Update docs links to new docs site
* Fix doc link to point to new docs site
* Update links to new docs site
* Update doc links to new docs site
* Update docs links
* Update docs
* Update docs
* Update doc links
* Update docs
* Update doc links
* Update doc links
* Update doc links
* updated documentation links in actions and secrets clients
* Update Octokit/Models/Response/SecretsPublicKey.cs
Removing line for consistency.
Co-authored-by: Thomas Hughes <iamhughes@github.com>
* Update Octokit/Models/Response/RepositorySecret.cs
Removing line for consistency.
Co-authored-by: Thomas Hughes <iamhughes@github.com>
* set default owner and repo
* switched to using the Helper.Organization from a ORG constant set at the top of the file
* swapped out variable at top of file for the Helper.Organization property
* switched to helper method to create new repositories
* Protected setters --> private setters in response models
* RepositorySecret needs protected setters
Co-authored-by: Mike Tolly <mike.tolly@takeda.com>
Co-authored-by: Thomas Hughes <iamhughes@github.com>
Co-authored-by: mptolly-takeda <61791994+mptolly-takeda@users.noreply.github.com>
* Initial implementation of ManagementConsole - maintenance mode
* Add environment var support for management console password for integration tests
* Add reactive client and unit tests
* Update some xmlDoc
* I think this is a better way to setup the underlying baseUri on IConneciton, to achieve managemet console access rather than requiring a specific GitHubClient that cant call normal API's
Instead, the management client methods can check the base Url and if it contains /api/v3/ they can set their relative endpoint Uri to include a leading "/" which will cause the /api/v3/ to be removed.
* Update EnterpriseClient.cs
Fix xml comments
* Update IEnterpriseClient.cs
Fix xml comments
* Still trying to get the xmDoc perfect, thanks app veyor :)
* XmlDoc'ing my way to success
* Add specific test attribute for management console tests
* check chronic string empty/null
* Use helper's password field in test
* Tidy up maintenance mode tests by using a context/destructor to manage the initial/end state of maintenance mode
* make internal and tidy up URL concatenation
* move GHE endpoint fixup inside ApiUrls methods
* Rework request object to be the correct structure so SimpleJsonSerializer can be used to serialize it. Remove MaintenanceDate class and just pass in the Date/string for when
Still need to use UrlFormEncoding rather than json in the POST body though...
* Create abstract base class for FormUrlEncoded parameters (similar to existing RequetParameters) and inherit from it in UpdateMaintenanceRequest
* Fix maintenance context logic - destructor should always turn maintenance OFF regardless of initial requested state
* Fix xml comment
* Fix Xml comment
* Those pesky xml comments!
* Fine, I give up!
* Fix string.Format
* fix bad rebase
* fix failing convention tests
* restore missing whitespace
* writing some docs
* some edits
* edit
* Attempt to handle both old and new annotations models so we support the changes on github.com as well as still support GHE2.14
add Path and AnnotationLevel fields
flag Filename and WarningLevel as deprecated/obsolete
also flag BlobHref as deprecated on NewCheckRunAnnotation
Adjust ctors to handle new and legacy field options
* adjust tests to remove use of obsoleted fields
* fix a couple of other tests using unrelated obsoleted fields
* Mark check suite Request method and request object as obsolete
* Add Rerequest() method to normal and observable clients
Add unit and integration tests
* add StartColumn and EndColumn as optional fields for CheckRunAnnotation response and NewCheckRunAnnotation request
* remove integration tests for Request() method as they no longer work on github.com anyway
* Adding functionality to query installations for user
* Rename method
* Adding installation methods
* Adding tests
* Adding observable client methods
* Adding InstallationResponse
* Adding GitHub Apps Installations Client
* Tweaking doc comments
* Undoing unintentional changes and cleaning up
* Reordering functions in clients to keep the same code look and feel
* Making sure all methods are documented with their authentication requirements
* Syntax error
* Renaming methods and tests
* Renaming property
* Test cleanup
* XmlDoc comment fixups and consistency
* rename User -To-Server auth methods from xxxForUser to xxxForCurrentUser
* rename GitHubAppsInstallationsClient to GitHubAppInstallationsClient to be consistent with single/plural naming conventions
* make method order match the order on github docs site
* tidy up usings
* correct implementation of GetALlInstallationsForCurrent method to be consistent
* Add missing unit and integration tests for ObservableGitHubAppsClient
* fix renamed method in observable tests
* Add EnsuresNonEmptyArguments tests and fixup asserts in GitHubAppsClient
* Add tests for new Observable client methods and fixup Null/Empty asserts in Observable client
* change non paginated call to call through to other method but with ApiOptions.None
* add unit tests for observable client and fixup errors they found
* add integration tests for new GitHubAppsClient methods, fixed an incorrect route that the tests found!
* add integration tests for extra methods on observable client
* add integration tests for new clients GitHubAppInstallationsClient and ObservableGitHubAppInstallationsClient
* deprecate renamed method properly, to avoid breaking change
* change existing CreateInstallationToken method to use new /app/installations route, and provide an obsolete CreateInstallationTokenPreview() method still using the old route, in order to support GHE 2.14
* suppress obsolete usage warning in tests
* add unit test for new method
* add new method to observable client
* fix routes in tests
* remove CreateInstallationTokenPreview() as it isnt actually required
* Add CheckRunEventPayload
* add CheckRunEventPayload into all the right places
* forgot integration tests for RepositoryId methods (+1 squashed commits)
Squashed commits:
[b2445bf3] Implement Create CheckRun methods for normal and observable clients including unit and integration tests and xmldoc comments
* Implement Update CheckRun method
Refactored NewCheckRun to inherit CheckRunUpdate since they share all fields except HeadSha
* Implement GetAllForReference method
* Implement GetAllForCheckSuite method
* tweak XmlDoc to match github documentation
* Implement Get method
* Implement GetAllAnnotations
Moved CheckRunAnnotation model from Request to Common and added a parameterless ctor, since it is now a response model as well as a request model
* Split common CheckRunAnnotation model into separate response and request models due to different field and ctor requirements
Rename other CheckRun request sub classes to be consistent with NewCheckRunAnnotation (eg NewCheckRunOutput, NewCheckRunImage, etc)
* add title field back into CheckRunAnnotation
* fix up XmlDocs
* fix mutable response property - hooray for convention tests!
* Check run request models
* Check Run response models
* Check run clients
* Check run ApiUrls and AcceptHeaders
* Pack it all together for now
* Add missing accept headers to connection calls
* Standardize class definitions
* Standardize function names
* Merge ICheckRunAnnotationsClient into ICheckRunsClient
* Properly organize clients
* Cleanup CheckRun response model
* Fix slug check run urls
* Add checks installation permission
* Use StringEnums where appropriate
* Cleanup check run output models
* Flesh out CheckSuite model
* Delete CheckRunsList
* Remove a sealed, fix some line endings
* Adding check suite models
* Skeleton check suite client implementation
* Add check suite ApiUrls
* Flesh out check suites client
* Add parameterless CheckRun constructor
* Add DebuggerDisplay to checks models
* Add observable checks interfaces
* Add return values to POST and PATCH check clients
* Fix some check suite client return values
* Skeleton reactive checks implementation
* Implement observable checks clients
* Remove rogue tabs
* Add CheckSuiteEventPayload
* Add CheckRunEventPayload
* Add DebuggerDisplay attributes to checks API payloads
* Properly nullables check suite/run conclusion
* Add CheckSuiteEventTests
* Fix checks client accessor naming issues
* Add missing Text field to CheckRunOutput
* Marks CheckRunUpdate's conclusion as nullable
* Fix reactive checks client naming
* Today I learned DateTimeOffset is a struct
Makes CheckRunUpdate's DateTimeOffsets nullable
* Modify check clients to put slug version before repo id version
* Add nullable to CheckRun.CompletedAt
* Implement parameterless ICheckRunsClient.GetAllForReference and GetAllForCheckSuite
* Add missing RequestParameters base to CheckSuiteRequest
* Implement checks API GetAll methods
* Bring parity to Reactive checks clients
* fix project settings to get GitHubApp helper working again
* remove un-needed InstallationId setting - provide helper method to find installation based on owner
* fix up request object ctors based on required/optional parameters
* fix up request object ctors based on required/optional parameters
* add some initial integration tests for CheckSuites and CheckRuns including some helper methods
* Add test for Request CheckSuite
Fix Request CheckSuite to use correct Uri
Fix Request CheckSuite return type as it doesnt return an object
Fix CheckSuiteTriggerRequest ctor to make required fields mandatory
* simplify Get CheckSuite test to not require as much data setup
* Add test for CheckSuite GetAllForReference
* Add test for CheckSuite UpdatePreferences
* rename response models
* rename CheckSuitesList to CheckSuitesResponse and use as response to the GetAll calls
* Fix tests
* Fix observable
* fix model convention tests
* remove CheckRuns so we can focus only on CheckSuites for now
* naming things is hard
* oh so many unit tests for CheckSuites methods
* make client mockable
* Fix issue with .Max() when no results returned
* fix request parameter names
* add Xml doc comments
* Add XmlDoc comments to request/common model objects
* rename class to match usage
* tidy ups
* xmldoc for observable clients
* fix method order
* add observable unit tests and get them passing
* Add Observable unit tests and get them passing
* add observable integration tests
* tidy up ApiUrl method name
* whitespace/using tidy ups
* Ensure CheckSuiteEventPayload class is handled in deserializer and add to activity test
* add response model XmlDoc comments
* missed one xmldoc
* add xmldoc to NewCheckSuite request and remove HeadBranch property as it doesnt exist anymore
* add some extra check suites integration tests
* Add "transfer repository" accept header
* Create RepositoryTransfer class
This will be used to send the POST request to initiate the transfer.
* Create Ensure method to check for empty or null arrays
* Change arg name in Ensure for nonempty arrays
array -> value
* Add xmldoc for ArgumentNotNullOrEmptyArray
* Create Transfer method in IRepositoriesClient
* Implement Transfer method in RepositoriesClient
* Fix typo in xmldoc for Transfer
* Add <returns> to Transfer xmldoc
* Create Transfer method in IObservableRepositoriesClient
* Implement Transfer in ObservableRepositoriesClient
* Add DebuggerDIsplayAttribute do RepositoryTransfer
* Add unit tests for RepositoryTransfer constructors
* Change TeamId property type to IReadOnlyList<int>
* Rewrite DebuggerDisplay property into something more succint
* Make new Ensure method into an IEnumerable<T> checker
* Add XmlDoc to RepositoryTransfer
* Tweaks to first ctor XmlDoc
* Create basic unit tests for Transfer
* Create ApiUrls.RepositoryTransfer
* Use ApiUrls.RepositoryTransfer to get URI in Transfer
Previous implementation used wrong URI
* Start implementing RepositoriesClientTests.TheTransferMethod
* Implement org -> user transfer integration test
* Implement user -> org transfer integration test
* [WIP] Implement user -> org transfer with teams
Implementation doesn't work, API usage seems correct.
* Mark transfer user -> org w/ teams integration test with FIXME
* Add second end point URI to ApiUrls
* Add other Transfer overload to RepositoriesClient for other end point
* Create unit tests for other Transfer endpoint
* Add overload to IRepositoriesClient
* Add integration tests for overload
* Reorganize unit tests for TheTransferMethod
* Rename id to repositoryId
* Reorganize unit tests for RepositoriesClientTests.Transfer
* Add second endpoint to IObservableRepositoriesClient
* Add XmlDoc to second Transfer endpoint
* Add XmlDoc to second Transfer endpoint in RepositoriesClient
* Reimplement "with teams" integration tests using TeamContext
* Rename integration test for consistency
* Add asserts to actual ownership transfer
* Rename RepositoryTransfer.TeamId property to TeamIds
* Add awaiit to ThrowsAsync in RepositoriesClientTests
* Put await in right places for unit tests
* Add Ensures for Transfer method in RepositoriesClient
* Add XmlDoc to ApiUrls.RepositoryTransfer with repo id
* Update XmlDoc for RepositoryTransfer constructor and teamIds property
* Rename currentOwner to owner
* Add Ensure guards to ObservableRepositoriesClient.Transfer methods
* Add unit tests for ObservableRepositoriesClient
* Implement new attributes for labels
* Include correct API header in all Labels calls
* Add integration tests for Create and Update methods for labels
* Use improved labels API in observable client
* found even more endpoints that need the preview header!
* RemoveFromIssue actually returns the list of remaining labels rather than null. This change should be source compatible but not binary compatible
* Implement new labels search method in SearchClient
* Implement reactive client SearchLabels
* Improve documentation for label search methods
* more comment tidy up
* Added pre-receive environment client
https://developer.github.com/v3/enterprise-admin/pre_receive_environments
* Added unit and integration tests for the pre-receive environments client
* moved test setup outside of tests
* fixed unit test
* Added reactive components for pre-receive environment endpoints
* Debugger display's and non public setters on response object conventions
* removed redundant parameter attributes
implemented update request independently of new request
changed ints to longs for future proofing
updated unit tests
changed update integration tests to create a new update request to ensure optional values function
* updating reactive environmentids to longs as well
* also converting response id to a long
* Fixed an incorrect unit test
renamed some test variable names for consistency
Added mockable ctors on responses, and parameterless ctors to maintain functionality
* Adding missing state parameter
* rename client member accessor to singular form in accordance with octokit naming conventions
* fixup tests
* add integration tests for observable client
* Added get release by tag endpoint
* Added integration tests for get release by tag overload
* tidy up integration tests and add reactive integration tests
* Implement repositoryId based method
* Implement repositoryId based method in Reactive client
* Added authentication using bearer token.
* Added Installation and AccessToken clients.
* Added new clients to Reactive project
* added support for DateTime serialized as FileTime
* added support for StatusEventPayload
* added support for StatusEventPayload
* Added test for StatusEventPayload and fixed serializer to return that event payload type.
* WIP - added ApplicationClient and related Api Urls.
* Continued implementing Installations support.
* Fixing build (WIP)
* fixed build
* added Account property to Installation. prefer nameof(x) over literal "x".
* fixed according to code review.
* fixed build.
* switched Installation ID from int to long.
* added Permissions and Events properties to Installation.
* added documentation to Application and Installation properties in IGitHubClient.
* wip - added tests to new clients
* wip - fix build
* wip - fixed build.
* added InstallationsClient tests.
* added integration test for InstallationsClient.
* changes requested in code review.
* add Get method for App
* Create GitHubApp response model instead of re-using existing Application response model
* add Get method to observable client
* fixed build (both locally and failed test).
* Fixed documentation and added some missing XML docs.
* added DebuggerDisplay to StatusEventPayload
* updated XML docs and added some missing bits. prefer nameof(x) over literal "x".
* Add xml comments to AccessToken response model and use DateTimeOffset rather than DateTime
* Tidy up XmlComments and make consistent across client and observable client and interfaces
* fixup unit tests to independently verify preview header
* Implement GetInstallation method
* revert commits unrelated to GitHubApps - these can be done on a separate PR if required
* this extra authenticator class doesnt appear to be used anywhere
* undo project file change as it doesnt appear to be necessary
* Revert "Merge remote-tracking branch 'remote/GitHubApps' into GitHubApps"
This reverts commit c53cc110b8d807f62fdfeaa7df19e1532d050007, reversing
changes made to 0c9e413d420a4725738644ea5b13af6ec102d456.
* Revert "Revert "Merge remote-tracking branch 'remote/GitHubApps' into GitHubApps""
This reverts commit 02d52b8adf814b6945c60cb59a907a8cd34b1ce7.
* add XmlDoc comments to response models and flesh out installation permissions
* name AcceptHeaders member consistently
* accidentally lost changes to Credentials.cs
* Enhance Intergation test framework to handle GitHubApp settings and discoer tests appropriately
Get code ready for GitHubJWT nuget package but for now just hardcode a JWT in ENV VAR
Add 1 integration test for each method and ensure they are working!
* fixed compiler warnings.
* Added support for Installation=>Id field that arrives in a Pull Request Event payload.
(See the last field in the sample JSON of https://developer.github.com/v3/activity/events/types/#pullrequestevent)
* Change integration test project to netcoreapp2.0 so we can use GitHubJwt nuget package in integration tests
* First cut at some GitHubApp doco
* update mkdocs config
* Moved the Installation property to ActivityPayload, so it's available in all payloads.
This feature is not undocumented, unfortunately, but valid:
https://platform.github.community/t/determining-which-installation-an-event-came-from/539/11
* Split Installation to Installation and InstallationId, and added a comfort method for gaining its AccessToken.
* fixed InstallationId CreateAccessToken to receive IGitHubAppsClient. added (and fixed) docs.
* reverted object-oriented style comfort method and it's docs.
* update all test projects to netcoreapp2.0
* tweak build configs to use 2.0.3 SDK
* also need to update cake frosting build to netcoreapp2.0
* tweak docs some more
* fix convention test failures
* test projects still had some old runtime parts in them!
* travis osx image needs to be at least 10.12 for .NET Core 2.0
* shell script might need the same argument tweak for cake
* more doc tweaks
* Make sure compiler warning output isnt somehow causing Linux and OSX builds to fail
* moar logging for linux/OSX builds
* stop sourcelink on linux/OSX builds to see if that is the problem
* set verbosity to detailed for the dotnet build step
* try new sourcelink and list out remotes
* is travis being weird with git clone?
* SourceLink may be defaulting to true on CI server so explicitly set it as false rather than omitting it
* detailed is a bit too verbose for travis, try normal
* turn sourcelink back on for Linux/OSX
* fix compiler warning
* Try SourceLink.Create.CommandLine instead of SourceLink.Create.GitHub
* CliToolReferences did not update to latest versions
* remove debug origin info
* turn off msbuild output
* go back to SourceLink.Create.GitHub!
* time diff between dev PC and API causes issues if specifying a full 600 second token
* handle extra date format that Installation end point now returns
* field needs to be protected in order to be deserialized
* provide even more buffer for client vs server clock drift
* Update to latest GitHubJwt reference
* go back to SDK 1 since SDK 2 is having sporadic travisCI faliures in TestSourceLink build step
* get appveyor working
* update sourcelink back to latest, and use SDK 1.04 (runtime 1.0.5)
* Add release notes
* Fix failing integration test
* Run FormatCode build task to tidy up whitespace
* Remove "UnkownUser" from release notes contributors
* Implement GetLicenseContents() method for getting repository's license info
* Request License Preview API for calls that return Repository object.
* Add missing accept headers to observable methods for ObservableRepositoriesClients
* fix impacted unit tests
