zoriya/react-native-svg
1
0
Fork 0
mirror of https://github.com/zoriya/react-native-svg.git synced 2026-08-16 02:44:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

Minor fix to prevent crash when Loaded fires twice (#2180)

Browse Source 
There are many reasons Loaded can fire twice. Usually, it will happen when the native SvgView component is moved, but it can also happen if an ancestor of SvgView is reparented. There is a crash that appears to occur when we attempt to call CreateResources twice. This resolves that crash.
This commit is contained in:
Eric Rozell
2023-11-28 10:42:20 +01:00
committed by GitHub
parent fc1c9a0347
commit 20de90d272
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
windows/RNSVG/SvgView.cpp
+4 -2
View File
@@ -202,8 +202,10 @@ void SvgView::CreateResources() {
void SvgView::Panel_Loaded(IInspectable const &sender, xaml::RoutedEventArgs const & /*args*/) {
if (auto const &svgView{sender.try_as<RNSVG::SvgView>()}) {
m_loaded = true;
svgView.CreateResources();
if (!m_loaded) {
m_loaded = true;
svgView.CreateResources();
}
}
}