zoriya/react-native-svg
1
0
Fork 0
mirror of https://github.com/zoriya/react-native-svg.git synced 2026-05-27 12:41:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

[macOS][Xcode 15] Avoid using dirtyRect in drawRect: (#2136)

Browse Source 
Apple made a breaking change in Xcode 15 / macOS Sonoma which breaks usages of drawRect:. You can no longer trust that the OS will provide you a dirtyRect will be within the bounds of your view. Specifically (from the appkit release notes):

Filling the dirty rect of a view inside of -drawRect. A fairly common pattern is to simply rect fill the dirty rect passed into an override of NSView.draw(). The dirty rect can now extend outside of your view’s bounds. This pattern can be adjusted by filling the bounds instead of the dirty rect, or by setting clipsToBounds = true.

This led to an unfortunate bug where any SVG drawn took up the full width/height of your window. Let's follow Apple's advice and draw using [self bounds] instead of dirtyRect.
This commit is contained in:
Saad Najmi
2023-09-20 06:22:24 -07:00
committed by GitHub
parent 234f7b7302
commit 23d65b9835
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
apple/Elements/RNSVGSvgView.mm
+1 -1
View File
@@ -293,7 +293,7 @@ using namespace facebook::react;
_boundingBox = rect;
CGContextRef context = UIGraphicsGetCurrentContext();
[self drawToContext:context withRect:rect];
[self drawToContext:context withRect:[self bounds]];
}
- (RNSVGPlatformView *)hitTest:(CGPoint)point withEvent:(UIEvent *)event