zoriya/react-native-svg
1
0
Fork 0
mirror of https://github.com/zoriya/react-native-svg.git synced 2025-12-06 07:06:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: remove package from AndroidManifest.xml (#2600)

Browse Source 
# Summary

Fixes #2599 

Starting with `v15.8.0`, we support `react-native@0.73+`, which
eliminates the need to worry about AGP versions below 7. Consequently,
the `package` attribute in `AndroidManifest.xml` can be safely removed,
along with the corresponding check in `build.gradle`.

## Test Plan

Build the app on all supported versions

## Compatibility

| OS      | Implemented |
| ------- | :---------: |
| Android |    ✅      |
This commit is contained in:
Jakub Grzywacz
2025-01-07 14:43:58 +01:00
committed by GitHub
parent c7743f1a41
commit 6377be5f20
2 changed files with 2 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
android/build.gradle
View File

@@ -81,10 +81,8 @@ def FRESCO_VERSION = getFrescoVersion()
android { android {
compileSdkVersion safeExtGet('compileSdkVersion', 28) compileSdkVersion safeExtGet('compileSdkVersion', 28)
namespace "com.horcrux.svg"
def agpVersion = com.android.Version.ANDROID_GRADLE_PLUGIN_VERSION def agpVersion = com.android.Version.ANDROID_GRADLE_PLUGIN_VERSION
if (agpVersion.tokenize('.')[0].toInteger() >= 7) {
namespace "com.horcrux.svg"
}
if (agpVersion.tokenize('.')[0].toInteger() >= 8) { if (agpVersion.tokenize('.')[0].toInteger() >= 8) {
buildFeatures { buildFeatures {
buildConfig = true buildConfig = true

3
android/src/main/AndroidManifest.xml
View File

@@ -1,2 +1 @@
<manifest package="com.horcrux.svg"> <manifest xmlns:android="http://schemas.android.com/apk/res/android"/>
</manifest>