feat: remove unused common folder (#1838)

PR removing common directory from library since it is not used currently due to no custom shadow nodes etc. in Fabric implementation.
This commit is contained in:
Wojciech Lewicki
2022-08-17 15:50:01 +02:00
committed by GitHub
parent 0a26639532
commit 778703d8a3
5 changed files with 1 additions and 55 deletions
-1
View File
@@ -4,7 +4,6 @@ on:
paths:
- '.github/workflows/android-build-test.yml'
- 'android/**'
- 'common/**'
- 'Example/android/**'
- 'FabricExample/android/**'
push:
+1 -10
View File
@@ -705,15 +705,6 @@ PODS:
- React-Codegen
- React-RCTFabric
- ReactCommon/turbomodule/core
- RNSVG/common (= 12.4.4)
- RNSVG/common (12.4.4):
- RCT-Folly
- RCTRequired
- RCTTypeSafety
- React
- React-Codegen
- React-RCTFabric
- ReactCommon/turbomodule/core
- SocketRocket (0.6.0)
- Yoga (1.14.0)
- YogaKit (1.18.1):
@@ -936,7 +927,7 @@ SPEC CHECKSUMS:
React-rncore: 55e35fbadf994c9efa605a78bf9d1fb3f080bc55
React-runtimeexecutor: 538c4d995c729b5247ac3149774f0a53f98570dd
ReactCommon: f7fc6b8b10e8f16f65a8009be266cfc1478fb20d
RNSVG: 79c1551169ce176cc9eadd5e320c62b8912fe315
RNSVG: 7b29007eb3f0c22975ee09c5cfab0459b1d78560
SocketRocket: fccef3f9c5cedea1353a9ef6ada904fde10d6608
Yoga: 65fe91a246110ebd54e9c7388d98e90d861cb4e7
YogaKit: f782866e155069a2cca2517aafea43200b01fd5a
-6
View File
@@ -38,12 +38,6 @@ Pod::Spec.new do |s|
s.dependency "RCTRequired"
s.dependency "RCTTypeSafety"
s.dependency "ReactCommon/turbomodule/core"
s.subspec "common" do |ss|
ss.source_files = "common/cpp/**/*.{cpp,h}"
ss.header_dir = "rnsvg"
ss.pod_target_xcconfig = { "HEADER_SEARCH_PATHS" => "\"$(PODS_TARGET_SRCROOT)/common/cpp\"" }
end
else
s.source_files = 'apple/**/*.{h,m,mm}'
s.exclude_files = 'apple/Utils/RNSVGFabricConversions.h'
-1
View File
@@ -1,7 +1,6 @@
SVG_MAIN_THIS_DIR := $(call my-dir)
include $(SVG_MAIN_THIS_DIR)/../../../build/generated/source/codegen/jni/Android.mk
include $(SVG_MAIN_THIS_DIR)/../../../../common/cpp/Android.mk
include $(CLEAR_VARS)
-37
View File
@@ -1,37 +0,0 @@
SVG_COMMON_THIS_DIR := $(call my-dir)
include $(CLEAR_VARS)
LOCAL_PATH := $(SVG_COMMON_THIS_DIR)
LOCAL_MODULE := rnsvg_common
LOCAL_C_INCLUDES := $(LOCAL_PATH) $(GENERATED_SRC_DIR)/codegen/jni
LOCAL_SRC_FILES := $(wildcard $(LOCAL_PATH)/**/*.cpp)
LOCAL_EXPORT_C_INCLUDES := $(LOCAL_PATH) $(GENERATED_SRC_DIR)/codegen/jni
# Please note as one of the library listed is libreact_codegen_samplelibrary
# This name will be generated as libreact_codegen_<library-name>
# where <library-name> is the one you specified in the Gradle configuration
LOCAL_SHARED_LIBRARIES := libjsi \
libfbjni \
libglog \
libfolly_runtime \
libyoga \
libreact_nativemodule_core \
libturbomodulejsijni \
librrc_view \
libreact_render_core \
libreact_render_graphics \
libfabricjni \
libreact_debug \
libreact_render_componentregistry \
libreact_render_debug \
libruntimeexecutor \
libreact_codegen_rncore \
libreact_codegen_rnsvg
LOCAL_CFLAGS := \
-DLOG_TAG=\"ReactNative\"
LOCAL_CFLAGS += -fexceptions -frtti -std=c++17 -Wall
include $(BUILD_SHARED_LIBRARY)