fix: video not loading when external subtitles are malformed (#4822)

2026-05-23 15:07:45 +00:00 · 2026-01-21 23:37:51 +01:00
parent 28e295a6ee
commit 86133e38cd
1 changed files with 12 additions and 5 deletions
@@ -67,11 +67,18 @@ enum ExternalSubtitlesUtils {
          withMediaType: .text,
          preferredTrackID: kCMPersistentTrackID_Invalid
        ) {
-          try compositionTextTrack.insertTimeRange(
-            CMTimeRange(start: .zero, duration: textTrack.timeRange.duration),
-            of: textTrack,
-            at: .zero
-          )
+          do {
+            try compositionTextTrack.insertTimeRange(
+              CMTimeRange(start: .zero, duration: textTrack.timeRange.duration),
+              of: textTrack,
+              at: .zero
+            )
+          } catch {
+            print(
+              "[ReactNativeVideo] Failed to insert text track into composition: \(error.localizedDescription). Language: \(textTrack.languageCode ?? "unknown"). Continuing without this subtitle track."
+            )
+            continue
+          }

          compositionTextTrack.languageCode = textTrack.languageCode
          compositionTextTrack.isEnabled = true