zoriya/react-native-web
1
0
Fork 0
mirror of https://github.com/zoriya/react-native-web.git synced 2026-05-31 17:53:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

[fix] default DOM element for 'View'

Browse Source 
There are certain contexts where using a `div` is invalid HTML and may
cause rendering issues. Change the default element created by
`createReactDOMComponent` to a `span`.

**Appendix**

The following HTML results a validator error.

  <!DOCTYPE html>
  <head>
  <meta charset="utf-8">
  <title>test</title>
  <button><div>a</div></button>

Error: Element `div` not allowed as child of element `button` in this
context.

Source: https://validator.w3.org/nu/#textarea
This commit is contained in:
Nicolas Gallagher
2016-07-11 20:25:05 -07:00
parent 640e41dc34
commit 41159bcb10
2 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/modules/createReactDOMComponent/__tests__/index-test.js
+3 -1
View File
@@ -43,7 +43,9 @@ suite('modules/createReactDOMComponent', () => {
test('prop "component"', () => { test('prop "component"', () => {
const component = 'main' const component = 'main'
const element = shallow(createReactDOMComponent({ component })) let element = shallow(createReactDOMComponent({}))
assert.equal(element.is('span'), true, 'Default element must be a "span"')
element = shallow(createReactDOMComponent({ component }))
assert.equal(element.is('main'), true) assert.equal(element.is('main'), true)
}) })
src/modules/createReactDOMComponent/index.js
+1 -1
View File
@@ -22,7 +22,7 @@ const createReactDOMComponent = ({
accessibilityLiveRegion, accessibilityLiveRegion,
accessibilityRole, accessibilityRole,
accessible = true, accessible = true,
component = 'div', component = 'span',
testID, testID,
type, type,
...other ...other