zoriya/react-native-web
1
0
Fork 0
mirror of https://github.com/zoriya/react-native-web.git synced 2026-05-27 00:06:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

[fix] View href 'target' string may start with underscore

Browse Source 
Close #1969
This commit is contained in:
Charlie Croom
2021-03-30 10:30:12 -04:00
committed by Nicolas Gallagher
parent 0ac406c91e
commit 781a4191f0
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-native-web/src/exports/View/__tests__/index-test.js
Vendored
+1 -1
View File
@@ -110,7 +110,7 @@ describe('components/View', () => {
const hrefAttrs = { const hrefAttrs = {
download: 'filename.jpg', download: 'filename.jpg',
rel: 'nofollow', rel: 'nofollow',
target: 'blank' target: '_blank'
}; };
const { container } = render(<View href="https://example.com" hrefAttrs={hrefAttrs} />); const { container } = render(<View href="https://example.com" hrefAttrs={hrefAttrs} />);
expect(container.firstChild).toMatchSnapshot(); expect(container.firstChild).toMatchSnapshot();
packages/react-native-web/src/exports/View/index.js
Vendored
+2 -2
View File
@@ -107,8 +107,8 @@ const View = forwardRef<ViewProps, *>((props, forwardedRef) => {
if (rel != null) { if (rel != null) {
supportedProps.rel = rel; supportedProps.rel = rel;
} }
if (typeof target === 'string' && target.charAt(0) !== '_') { if (typeof target === 'string') {
supportedProps.target = '_' + target; supportedProps.target = target.charAt(0) !== '_' ? '_' + target : target;
} }
} }