mirror of
https://github.com/zoriya/react-native-web.git
synced 2026-05-22 22:44:52 +00:00
[fix] V8 deopt in compiled 'createDOMElement'
Fixes V8 "deopt" warning: "Bad value context for arguments value".
This deopt was caused by the babel-compiled output of the ES6 argument
default value for 'rnProps':
var t = arguments.length > 1 && void 0 !== arguments[1]
? arguments[1]
: l
Not relying on ES6 default arguments avoids the function 'deopt'.
This commit is contained in:
@@ -19,7 +19,7 @@ const roleComponents = {
|
||||
region: 'section'
|
||||
};
|
||||
|
||||
const createDOMElement = (component, rnProps = emptyObject) => {
|
||||
const createDOMElement = (component, rnProps) => {
|
||||
const {
|
||||
accessibilityLabel,
|
||||
accessibilityLiveRegion,
|
||||
@@ -29,7 +29,7 @@ const createDOMElement = (component, rnProps = emptyObject) => {
|
||||
testID,
|
||||
type,
|
||||
...domProps
|
||||
} = rnProps;
|
||||
} = rnProps || emptyObject;
|
||||
|
||||
const accessibilityComponent = accessibilityRole && roleComponents[accessibilityRole];
|
||||
const Component = accessibilityComponent || component;
|
||||
|
||||
Reference in New Issue
Block a user