refactor(skin): simplify buffering indicator

This commit is contained in:
Rahim
2026-06-24 12:21:55 -07:00
parent e07db4f7b2
commit 5969680809
9 changed files with 13 additions and 29 deletions
@@ -42,9 +42,7 @@ function getTemplateHTML() {
</media-poster>
<media-buffering-indicator class="${bufferingIndicator.root}">
<div class="${bufferingIndicator.container}">
${renderIcon('spinner')}
</div>
${renderIcon('spinner')}
</media-buffering-indicator>
<media-error-dialog class="${error.root}">
@@ -49,9 +49,7 @@ function getTemplateHTML() {
</media-poster>
<media-buffering-indicator class="${bufferingIndicator.root}">
<div class="${bufferingIndicator.container}">
${renderIcon('spinner')}
</div>
${renderIcon('spinner')}
</media-buffering-indicator>
<media-error-dialog class="${error.root}">
@@ -217,15 +217,9 @@ export function LiveVideoSkinTailwind(props: LiveVideoSkinProps): ReactNode {
/>
)}
<BufferingIndicator
render={(props) => (
<div {...props} className={bufferingIndicator.root}>
<div className={bufferingIndicator.container}>
<SpinnerIcon className={icon} />
</div>
</div>
)}
/>
<BufferingIndicator className={bufferingIndicator.root}>
<SpinnerIcon className={icon} />
</BufferingIndicator>
<ErrorDialog.Root>
<ErrorDialog.Popup className={error.root}>
@@ -53,6 +53,7 @@ describe('skins compiler config', () => {
expect(compactCode).toContain(compact('<BufferingIndicator className={bufferingIndicator.root}>'));
expect(compactCode).toContain(compact('<SpinnerIcon className={icon} />'));
expect(compactCode).not.toContain('BufferingIndicatorRoot');
expect(compactCode).not.toContain('bufferingIndicator.container');
expect(compactCode).toContain(compact('<ErrorDialog.Popup className={error.popup}>'));
expect(compactCode).toContain(
compact('<ErrorDialog.Title className={error.title}>Something went wrong.</ErrorDialog.Title>')
@@ -366,15 +366,9 @@ export function VideoSkinTailwind(props: VideoSkinProps): ReactNode {
/>
)}
<BufferingIndicator
render={(props) => (
<div {...props} className={bufferingIndicator.root}>
<div className={bufferingIndicator.container}>
<SpinnerIcon className={icon} />
</div>
</div>
)}
/>
<BufferingIndicator className={bufferingIndicator.root}>
<SpinnerIcon className={icon} />
</BufferingIndicator>
<ErrorDialog.Root>
<ErrorDialog.Popup className={error.root}>
@@ -75,7 +75,7 @@ export const popup = {
export const bufferingIndicator = {
...baseBufferingIndicator,
container: cn(baseBufferingIndicator.container, surface),
root: cn(baseBufferingIndicator.root, surface),
};
/* ===========================================================================
@@ -1,4 +1,3 @@
export const bufferingIndicator = {
root: 'absolute inset-0 hidden items-center justify-center pointer-events-none text-white not-data-visible:[--media-spinner-animation:none] data-visible:flex',
container: 'p-1 rounded-full',
root: 'absolute inset-0 m-auto hidden size-fit items-center justify-center pointer-events-none rounded-full p-1 text-white not-data-visible:[--media-spinner-animation:none] data-visible:flex',
};
@@ -178,7 +178,7 @@ export const menu = {
export const bufferingIndicator = {
...baseBufferingIndicator,
container: cn(baseBufferingIndicator.container, surface),
root: cn(baseBufferingIndicator.root, surface),
};
/* ===========================================================================
@@ -1,2 +1,2 @@
export const bufferingIndicator =
'absolute inset-0 hidden items-center justify-center pointer-events-none text-white not-data-visible:[--media-spinner-animation:none] data-visible:flex';
'absolute inset-0 m-auto hidden size-fit items-center justify-center pointer-events-none rounded-full p-1 text-white not-data-visible:[--media-spinner-animation:none] data-visible:flex';