zoriya/v10
1
0
Fork 0
mirror of https://github.com/zoriya/v10.git synced 2026-08-13 17:40:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(core): use 0.2 and 0.7 for default playback rates (#1236)

Browse Source
This commit is contained in:
rahim
2026-04-06 22:25:44 -07:00
committed by GitHub
parent c68c1a3c82
commit 932949fdf1
3 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/core/src/core/ui/playback-rate-button/tests/playback-rate-button-core.test.ts
+4 -4
View File
@@ -6,7 +6,7 @@ import { PlaybackRateButtonCore } from '../playback-rate-button-core';
function createMediaState(overrides: Partial<MediaPlaybackRateState> = {}): MediaPlaybackRateState {
return {
playbackRates: [0.25, 0.5, 0.75, 1, 1.2, 1.5, 1.7, 2],
playbackRates: [0.2, 0.5, 0.7, 1, 1.2, 1.5, 1.7, 2],
playbackRate: 1,
setPlaybackRate: vi.fn(),
...overrides,
@@ -96,7 +96,7 @@ describe('PlaybackRateButtonCore', () => {
const core = new PlaybackRateButtonCore();
const media = createMediaState({ playbackRate: 2 });
core.cycle(media);
expect(media.setPlaybackRate).toHaveBeenCalledWith(0.25);
expect(media.setPlaybackRate).toHaveBeenCalledWith(0.2);
});
it('advances through the middle of the list', () => {
@@ -124,12 +124,12 @@ describe('PlaybackRateButtonCore', () => {
const core = new PlaybackRateButtonCore();
const media = createMediaState({ playbackRate: 3 });
core.cycle(media);
expect(media.setPlaybackRate).toHaveBeenCalledWith(0.25);
expect(media.setPlaybackRate).toHaveBeenCalledWith(0.2);
});
it('cycles through sub-1x rates', () => {
const core = new PlaybackRateButtonCore();
const media = createMediaState({ playbackRate: 0.25 });
const media = createMediaState({ playbackRate: 0.2 });
core.cycle(media);
expect(media.setPlaybackRate).toHaveBeenCalledWith(0.5);
});
packages/core/src/dom/store/features/playback-rate.ts
+1 -1
View File
@@ -3,7 +3,7 @@ import { listen } from '@videojs/utils/dom';
import type { MediaPlaybackRateState } from '../../../core/media/state';
import { definePlayerFeature } from '../../feature';
const DEFAULT_RATES: readonly number[] = [0.25, 0.5, 0.75, 1, 1.2, 1.5, 1.7, 2];
const DEFAULT_RATES: readonly number[] = [0.2, 0.5, 0.7, 1, 1.2, 1.5, 1.7, 2];
export const playbackRateFeature = definePlayerFeature({
name: 'playbackRate',
site/src/content/docs/reference/playback-rate-button.mdx
+1 -1
View File
@@ -37,7 +37,7 @@ import basicUsageHtmlTs from "@/components/docs/demos/playback-rate-button/html/
## Behavior
Cycles through playback rates on click. The default rate list is `[1, 1.2, 1.5, 1.7, 2]`. After the last rate, it wraps back to the first. If the current rate isn't in the list (e.g., set programmatically), the button jumps to the next rate greater than the current one.
Cycles through playback rates on click. The default rate list is `[0.2, 0.5, 0.7, 1, 1.2, 1.5, 1.7, 2]`. After the last rate, it wraps back to the first. If the current rate isn't in the list (e.g., set programmatically), the button jumps to the next rate greater than the current one.
## Styling