zoriya/v10
1
0
Fork 0
mirror of https://github.com/zoriya/v10.git synced 2026-08-16 02:45:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

wip(spf): cast instead of re-guarding resolved presentation in the derive effect

Browse Source 
#5 review: the isResolvedPresentation guard in the derive effect's update() was
runtime-redundant — the monitor gates `monitoring` on a resolved presentation and
transitions before effects re-run, so `current` is always resolved there. Drop the
guard and cast to `Presentation`, with a comment citing the invariant.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
Christian Pillsbury
2026-07-10 07:30:30 -07:00
co-authored by Claude Opus 4.8
parent b820064b77
commit a304067c53
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/spf/src/playback/behaviors/establish-start-media-time.ts
+4 -1
View File
@@ -157,8 +157,11 @@ function establishStartMediaTimeSetup({
const containerData = state.mediaContainerData.get();
if (!containerData) return;
const startMediaTimes = derive(containerData, selectionContext());
// `current` is always resolved here — the monitor gates `monitoring` on a
// resolved presentation and transitions before effects re-run — so we cast
// to `Presentation` rather than re-narrowing.
update(state.presentation as Signal<MaybeResolvedPresentation>, (current) =>
isResolvedPresentation(current) ? stampTracks(current, startMediaTimes) : current
stampTracks(current as Presentation, startMediaTimes)
);
},
},