fix(site): update text link hover style to gold underline (#1149)

Co-authored-by: Claude <noreply@anthropic.com>

site/src/components/Footer.astro

@@ -97,12 +97,12 @@ const { class: className } = Astro.props;
       >
         Video.js is a free and open source HTML5 <a
           href="/"
-          class="underline intent:no-underline">video player.</a
+          class="underline intent:decoration-gold">video player.</a
         >
         <br />
         Video hosting and streaming <a
           href={MUX_URL}
-          class="underline intent:no-underline"
+          class="underline intent:decoration-gold"
           >sponsored by Mux
         </a>
 

site/src/components/FooterDocs.astro

@@ -91,11 +91,11 @@ const { class: className } = Astro.props;
     >
       Video.js is a free and open source HTML5 <a
         href="/"
-        class="underline intent:no-underline">video player.</a
+        class="underline intent:decoration-gold">video player.</a
       >
       <br class="@5xl:hidden" />Video hosting and streaming <a
         href={MUX_URL}
-        class="underline intent:no-underline"
+        class="underline intent:decoration-gold"
         >sponsored by Mux.
       </a>
       <br />

site/src/components/LegacyBanner.astro

@@ -15,7 +15,7 @@ import { BANNER_DISMISS_KEY } from '@/consts';
     Using Video.js v8 or earlier?{" "}
     <a
       href="https://legacy.videojs.org"
-      class="font-bold whitespace-nowrap underline intent:no-underline"
+      class="font-bold whitespace-nowrap underline intent:decoration-gold"
     >
       Visit legacy.videojs.org
     </a>

site/src/components/blog/BlogPostCard.astro

@@ -23,7 +23,7 @@ const { post, authors, asLink } = Astro.props;
     </time>
     <div class="mb-3">
       <h2
-        class="mb-3 font-display text-h25 leading-tight uppercase underline group-intent:no-underline"
+        class="mb-3 font-display text-h25 leading-tight uppercase underline group-intent:decoration-gold"
       >
         {post.data.title}
       </h2>

site/src/components/docs/EditPageButton.astro

@@ -15,7 +15,7 @@ const editUrl = `${GITHUB_REPO_URL}edit/main/${filePath}`;
     href={editUrl}
     target="_blank"
     rel="noopener noreferrer"
-    class="text-p3 underline intent:no-underline"
+    class="text-p3 underline intent:decoration-gold"
   >
     Edit page
   </a>

site/src/components/installation/RendererPicker.tsx

@@ -12,7 +12,7 @@ export default function RendererPicker() {
       <div className="flex flex-col gap-4">
         <p className="font-bold">
           Or upload your media for free to{' '}
-          <a href={MUX_URL} target="_blank" rel="noopener" className="underline intent:no-underline">
+          <a href={MUX_URL} target="_blank" rel="noopener" className="underline intent:decoration-gold">
             Mux
           </a>
         </p>

site/src/components/installation/RendererSelect.tsx

@@ -88,7 +88,7 @@ export default function RendererSelect() {
               <button
                 type="button"
                 onClick={() => renderer.set(detection.renderer)}
-                className="cursor-pointer underline intent:no-underline"
+                className="cursor-pointer underline intent:decoration-gold"
               >
                 Select {detection.label}
               </button>

site/src/components/installation/UploaderOverlay.tsx

@@ -45,7 +45,7 @@ export default function UploaderOverlay({ state, error, playbackId, onLogin, onR
       <OverlayWrapper>
         <p className="text-p3 font-bold">
           To upload this video to{' '}
-          <a href={MUX_URL} target="_blank" rel="noopener" className="underline intent:no-underline">
+          <a href={MUX_URL} target="_blank" rel="noopener" className="underline intent:decoration-gold">
             Mux
           </a>
           &hellip;
@@ -82,7 +82,7 @@ export default function UploaderOverlay({ state, error, playbackId, onLogin, onR
           <a
             href="https://dashboard.mux.com/my/video/assets"
             target="_blank"
-            className="underline intent:no-underline"
+            className="underline intent:decoration-gold"
             rel="noopener"
           >
             manage on Mux
@@ -100,7 +100,7 @@ export default function UploaderOverlay({ state, error, playbackId, onLogin, onR
           Error preparing video:
           {error}
         </p>
-        <button type="button" onClick={onRetry} className="text-p3 underline intent:no-underline">
+        <button type="button" onClick={onRetry} className="text-p3 underline intent:decoration-gold">
           Try again
         </button>
       </OverlayWrapper>

site/src/components/typography/styles.ts

@@ -6,7 +6,7 @@
  * HTML generation.
  */
 export const shared = {
-  a: 'underline intent:no-underline',
+  a: 'underline intent:decoration-gold',
   code: 'border border-manila-75 bg-manila-25 dark:bg-soot dark:border-warm-gray px-1 rounded font-mono text-code normal-case break-words',
   codeBlock: 'font-mono text-code text-manila-light',
   pre: 'shiki astro-code',

site/src/utils/docs/__tests__/renderInlineMarkdown.test.ts

@@ -41,7 +41,7 @@ describe('renderInlineMarkdown', () => {
     const result = renderInlineMarkdown('[link](https://example.com)');
     expect(result).toContain('href="https://example.com"');
     expect(result).toContain('underline');
-    expect(result).toContain('intent:no-underline');
+    expect(result).toContain('intent:decoration-gold');
   });
 
   it('renders unordered lists', () => {