Files
v10/CLAUDE.md
T

239 lines
7.6 KiB
Markdown
Raw Blame History

This file contains ambiguous Unicode characters
This file contains Unicode characters that might be confused with other characters. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.
# CLAUDE.md
Guidance for **Claude Code** (claude.ai/code) and other AI agents working with this repository.
## Overview
**Video.js 10** is a **Turborepomanaged monorepo**, organized by runtime and platform.
Refer to **[`CONTRIBUTING.md`](./CONTRIBUTING.md)** for setup, development, and lint/test instructions.
## Package Layout
| Package Path | Purpose |
| ----------------------- | ------------------------------------------------------------------ |
| `packages/utils` | Shared utilities (`/dom` subpath for DOMspecific helpers). |
| `packages/core` | Core runtimeagnostic logic (`/dom` subpath for DOM bindings). |
| `packages/store` | State management (`/dom` and `/react` subpaths for platform APIs). |
| `packages/html` | Web player—DOM/Browserspecific implementation. |
| `packages/react` | React player—adapts core state to React components. |
| `packages/react-native` | React Native player integration layer. |
| `examples/*` | Demo apps for various runtimes. |
| `site/` | Astrobased docs and website. |
IGNORE `packages/__tech-preview__/` — it's legacy code from the Demuxed demo. Don't reference or
modify it when working in other packages.
### Dependency Hierarchy
```text
utils/* ← shared utilities
utils/dom ← DOM-specific helpers
store ← state management
store/dom ← DOM platform APIs
store/react ← React bindings
core ← runtime-agnostic logic
core/dom ← DOM bindings
html ← Web player (DOM/Browser)
react ← React player
react-native ← React Native player
```
```text
utils ← store ← core ← html / react / react-native
```
## Workspace
- Uses **PNPM workspaces** + **Turbo** for task orchestration.
- Internal deps are linked with `workspace:*`.
- Always use PNPM, do not use other package managers.
### Common Root Commands
```bash
# Install workspace deps
pnpm install
# Run all demos/sites in parallel
pnpm dev
# Typecheck across repo (fast - uses TypeScript project references)
# Always run from root, not per-package
pnpm typecheck
# Build all packages/apps
pnpm build
# Build all packages (no apps)
pnpm build:packages
# Build specific package
pnpm -F <pkg> build
# Run tests across all packages
pnpm test
# Run tests for specific package
pnpm -F <pkg> test
# Run tests matching a name or pattern
pnpm -F <pkg> test -t "test name pattern"
# Run tests for a specific file
pnpm -F <pkg> test src/path/to/file.test.ts
# Run tests matching a glob or filter
pnpm -F <pkg> test src/core
# Lint all workspace packages
pnpm lint
# Lint and fix a single file
pnpm lint:fix:file <file>
# Remove all dist and types outputs
pnpm clean
```
## Dev Workflow
1. Make changes.
2. If you added/changed **exported types** in a package, run `pnpm -F <pkg> build` first.
- `pnpm typecheck` uses TypeScript project references against **built** `.d.ts` files.
- New/changed types won't be visible until `tsdown` builds them.
3. Typecheck, fix all issues.
4. Run test/s, fix all issues. If there are no tests add them.
5. Lint file/s, fix all issues.
6. Run build/s, fix all errors.
7. Before creating a PR `pnpm test`.
Be efficient when running operations, see "Common Root Commands".
## Testing
### File Organization
Tests live in a `tests/` directory next to the implementation they cover:
```text
packages/utils/src/dom/
├── listen.ts
├── event.ts
└── tests/
├── listen.test.ts
└── event.test.ts
```
### Conventions
- Use Vitest as the test runner.
- Import test utilities from `vitest`: `describe`, `it`, `expect`, `vi`.
- Name test files `<module>.test.ts` matching the source file.
- Write or update matching tests for each new or modified behavior.
- Follow the `act → assert` pattern.
- Use `vi.fn()` for mocks and spies.
## Guidelines
When generating or editing code in this repository, follow these rules to ensure safe, highquality contributions:
1. **Edit Precisely**
- Modify only the relevant lines or files.
- Never overwrite large sections or regenerate entire files.
- Preserve comments, type signatures, and existing code style.
2. **Match Existing Conventions**
- Follow the repos Prettier, ESLint, and TypeScript settings automatically.
- Use consistent naming (camelCase for variables, PascalCase for components).
- Prefer imports ordered and sorted as per `@antfu/eslint-config`.
3. **Type Safety First**
- Never remove or bypass TypeScript types.
- Avoid `any`; use `unknown` and proper narrowing if needed.
- Always ensure edits pass `pnpm typecheck`.
4. **FrameworkAgnostic Mindset**
- Core modules must remain DOM and frameworkindependent.
- Place platformspecific logic in the appropriate directory or adapter (HTML, React, RN).
5. **A11y, Styling & Performance**
- Maintain accessibility: ARIA roles, keyboard interactions, focus management.
- Use dataattributes and CSS variables for style hooks—no inline animation JS.
- Ensure logic runs at 60 FPS; prefer CSS transitions over manual DOM mutations.
6. **Commit Scope**
- Use semantic commit messages (enforced by `commitlint`).
- One focused change per commit—no mixed updates.
- Breaking changes use `!`.
## Code Rules
Prefer existing utilities over inline implementations:
| Instead of | Use |
| ------------------------- | ------------------------------------------------------ |
| `x === undefined` | `isUndefined(x)` from `@videojs/utils/predicate` |
| `x === null` | `isNull(x)` from `@videojs/utils/predicate` |
| `typeof x === 'function'` | `isFunction(x)` from `@videojs/utils/predicate` |
| `typeof x === 'string'` | `isString(x)` from `@videojs/utils/predicate` |
Before writing new helpers, check `@videojs/utils` for existing utilities.
### Naming Conventions
| Pattern | Prefix | Example |
| ------------------- | ---------- | -------------------------------- |
| Type inference | `Infer*` | `InferSliceState<S>` |
| Type resolution | `Resolve*` | `ResolveRequestHandler<R>` |
| Type constraint | `Ensure*` | `EnsureTaskRecord<T>` |
| Union type helpers | `Union*` | `UnionSliceState<Slices>` |
| Default loose types | `Default*` | `DefaultTaskRecord` |
| Type guards | `is*` | `isStoreError(error)` |
| Factory functions | `create*` | `createQueue()`, `createSlice()` |
### Type Guards
Always return `value is Type` for proper type narrowing:
```ts
function isStoreError(error: unknown): error is StoreError {
return error instanceof StoreError;
}
```
### Subscribe Pattern
Subscriptions return an unsubscribe function:
```ts
subscribe(listener: Listener): () => void {
this.#subscribers.add(listener);
return () => this.#subscribers.delete(listener);
}
```
### Optional Key Parameter
Methods that operate on one or all items use optional key:
```ts
// If key provided: operate on that item
// If no key: operate on all items
reset(key?: keyof Tasks): void {
if (!isUndefined(key)) {
// Single item
return;
}
// All items
}
```
### Destroy Pattern
Guard re-entry, set flag first, cleanup in order:
```ts
destroy(): void {
if (this.#destroyed) return;
this.#destroyed = true;
this.abort();
this.#subscribers.clear();
}
```