zoriya/octokit.net
1
0
Fork 0
mirror of https://github.com/zoriya/octokit.net.git synced 2025-12-06 07:16:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

remove Get<T> extension method and update impacted tests to use correct method, removing the need for

Browse Source 
additional nulls in tests
This commit is contained in:
Brendan Forster
2016-01-25 14:57:15 +10:30
parent da45d9ebf6
commit 46d9e1f745
26 changed files with 53 additions and 58 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
Octokit.Tests/Clients/BlobClientTests.cs
View File

@@ -21,8 +21,7 @@ namespace Octokit.Tests.Clients
client.Get("fake", "repo", "123456ABCD");
connection.Received().Get<Blob>(Arg.Is<Uri>(u => u.ToString() == "repos/fake/repo/git/blobs/123456ABCD"),
null);
connection.Received().Get<Blob>(Arg.Is<Uri>(u => u.ToString() == "repos/fake/repo/git/blobs/123456ABCD"));
}
[Fact]

2
Octokit.Tests/Clients/CommitStatusClientTests.cs
View File

@@ -54,7 +54,7 @@ namespace Octokit.Tests.Clients
client.GetCombined("fake", "repo", "sha");
connection.Received()
.Get<CombinedCommitStatus>(Arg.Is<Uri>(u => u.ToString() == "repos/fake/repo/commits/sha/status"), null);
.Get<CombinedCommitStatus>(Arg.Is<Uri>(u => u.ToString() == "repos/fake/repo/commits/sha/status"));
}
[Fact]

2
Octokit.Tests/Clients/CommitsClientTests.cs
View File

@@ -32,7 +32,7 @@ public class CommitsClientTests
client.Get("owner", "repo", "reference");
connection.Received().Get<Commit>(Arg.Is<Uri>(u => u.ToString() == "repos/owner/repo/git/commits/reference"), null);
connection.Received().Get<Commit>(Arg.Is<Uri>(u => u.ToString() == "repos/owner/repo/git/commits/reference"));
}
}

2
Octokit.Tests/Clients/FeedsClientTests.cs
View File

@@ -31,7 +31,7 @@ namespace Octokit.Tests.Clients
feedsClient.GetFeeds();
connection.Received().Get<Feed>(Arg.Is<Uri>(u => u.ToString() == "feeds"), null);
connection.Received().Get<Feed>(Arg.Is<Uri>(u => u.ToString() == "feeds"));
}
}
}

2
Octokit.Tests/Clients/GistCommentsClientTests.cs
View File

@@ -26,7 +26,7 @@ public class GistCommentsClientTests
await client.Get("24", 1337);
connection.Received().Get<GistComment>(Arg.Is<Uri>(u => u.ToString() == "gists/24/comments/1337"), null);
connection.Received().Get<GistComment>(Arg.Is<Uri>(u => u.ToString() == "gists/24/comments/1337"));
}
}

2
Octokit.Tests/Clients/GistsClientTests.cs
View File

@@ -20,7 +20,7 @@ public class GistsClientTests
client.Get("1");
connection.Received().Get<Gist>(Arg.Is<Uri>(u => u.ToString() == "gists/1"), null);
connection.Received().Get<Gist>(Arg.Is<Uri>(u => u.ToString() == "gists/1"));
}
}

3
Octokit.Tests/Clients/IssueCommentsClientTests.cs
View File

@@ -20,8 +20,7 @@ public class IssueCommentsClientTests
client.Get("fake", "repo", 42);
connection.Received().Get<IssueComment>(Arg.Is<Uri>(u => u.ToString() == "repos/fake/repo/issues/comments/42"),
null);
connection.Received().Get<IssueComment>(Arg.Is<Uri>(u => u.ToString() == "repos/fake/repo/issues/comments/42"));
}
[Fact]

3
Octokit.Tests/Clients/IssuesClientTests.cs
View File

@@ -21,8 +21,7 @@ namespace Octokit.Tests.Clients
client.Get("fake", "repo", 42);
connection.Received().Get<Issue>(Arg.Is<Uri>(u => u.ToString() == "repos/fake/repo/issues/42"),
null);
connection.Received().Get<Issue>(Arg.Is<Uri>(u => u.ToString() == "repos/fake/repo/issues/42"));
}
[Fact]

3
Octokit.Tests/Clients/IssuesEventsClientTests.cs
View File

@@ -64,8 +64,7 @@ namespace Octokit.Tests.Clients
client.Get("fake", "repo", 42);
connection.Received().Get<IssueEvent>(Arg.Is<Uri>(u => u.ToString() == "repos/fake/repo/issues/events/42"),
null);
connection.Received().Get<IssueEvent>(Arg.Is<Uri>(u => u.ToString() == "repos/fake/repo/issues/events/42"));
}
[Fact]

3
Octokit.Tests/Clients/IssuesLabelsClientTests.cs
View File

@@ -67,8 +67,7 @@ namespace Octokit.Tests.Clients
client.Get("fake", "repo", "label");
connection.Received().Get<Label>(Arg.Is<Uri>(u => u.ToString() == "repos/fake/repo/labels/label"),
null);
connection.Received().Get<Label>(Arg.Is<Uri>(u => u.ToString() == "repos/fake/repo/labels/label"));
}
[Fact]

3
Octokit.Tests/Clients/MilestonesClientTests.cs
View File

@@ -19,8 +19,7 @@ namespace Octokit.Tests.Clients
client.Get("fake", "repo", 42);
connection.Received().Get<Milestone>(Arg.Is<Uri>(u => u.ToString() == "repos/fake/repo/milestones/42"),
null);
connection.Received().Get<Milestone>(Arg.Is<Uri>(u => u.ToString() == "repos/fake/repo/milestones/42"));
}
[Fact]

2
Octokit.Tests/Clients/OrganizationsClientTests.cs
View File

@@ -31,7 +31,7 @@ namespace Octokit.Tests.Clients
orgsClient.Get("orgName");
client.Received().Get<Organization>(Arg.Is<Uri>(u => u.ToString() == "orgs/orgName"), null);
client.Received().Get<Organization>(Arg.Is<Uri>(u => u.ToString() == "orgs/orgName"));
}
[Fact]

3
Octokit.Tests/Clients/PullRequestReviewCommentsClientTests.cs
View File

@@ -180,8 +180,7 @@ public class PullRequestReviewCommentsClientTests
client.GetComment("fakeOwner", "fakeRepoName", 53);
connection.Received().Get<PullRequestReviewComment>(Arg.Is<Uri>(u => u.ToString() == "repos/fakeOwner/fakeRepoName/pulls/comments/53"),
null);
connection.Received().Get<PullRequestReviewComment>(Arg.Is<Uri>(u => u.ToString() == "repos/fakeOwner/fakeRepoName/pulls/comments/53"));
}
[Fact]

3
Octokit.Tests/Clients/PullRequestsClientTests.cs
View File

@@ -18,8 +18,7 @@ namespace Octokit.Tests.Clients
client.Get("fake", "repo", 42);
connection.Received().Get<PullRequest>(Arg.Is<Uri>(u => u.ToString() == "repos/fake/repo/pulls/42"),
null);
connection.Received().Get<PullRequest>(Arg.Is<Uri>(u => u.ToString() == "repos/fake/repo/pulls/42"));
}
[Fact]

2
Octokit.Tests/Clients/ReferencesClientTests.cs
View File

@@ -40,7 +40,7 @@ namespace Octokit.Tests.Clients
await client.Get("owner", "repo", "heads/develop");
connection.Received().Get<Reference>(Arg.Is<Uri>(u => u.ToString() == "repos/owner/repo/git/refs/heads/develop"), null);
connection.Received().Get<Reference>(Arg.Is<Uri>(u => u.ToString() == "repos/owner/repo/git/refs/heads/develop"));
}
}

5
Octokit.Tests/Clients/ReleasesClientTests.cs
View File

@@ -44,8 +44,7 @@ namespace Octokit.Tests.Clients
client.Get("fake", "repo", 1);
connection.Received().Get<Release>(Arg.Is<Uri>(u => u.ToString() == "repos/fake/repo/releases/1"),
null);
connection.Received().Get<Release>(Arg.Is<Uri>(u => u.ToString() == "repos/fake/repo/releases/1"));
}
[Fact]
@@ -228,7 +227,7 @@ namespace Octokit.Tests.Clients
client.GetAsset("fake", "repo", 1);
connection.Received().Get<ReleaseAsset>(Arg.Is<Uri>(u => u.ToString() == "repos/fake/repo/releases/assets/1"), null);
connection.Received().Get<ReleaseAsset>(Arg.Is<Uri>(u => u.ToString() == "repos/fake/repo/releases/assets/1"));
}
[Fact]

10
Octokit.Tests/Clients/RepositoriesClientTests.cs
View File

@@ -245,7 +245,7 @@ namespace Octokit.Tests.Clients
client.Get("fake", "repo");
connection.Received().Get<Repository>(Arg.Is<Uri>(u => u.ToString() == "repos/fake/repo"), null);
connection.Received().Get<Repository>(Arg.Is<Uri>(u => u.ToString() == "repos/fake/repo"));
}
[Fact]
@@ -487,7 +487,7 @@ namespace Octokit.Tests.Clients
client.GetAllLanguages("owner", "name");
connection.Received()
.Get<Dictionary<string, long>>(Arg.Is<Uri>(u => u.ToString() == "repos/owner/name/languages"), null);
.Get<Dictionary<string, long>>(Arg.Is<Uri>(u => u.ToString() == "repos/owner/name/languages"));
}
[Fact]
@@ -641,7 +641,7 @@ namespace Octokit.Tests.Clients
client.Compare("owner", "repo", "base", "head");
connection.Received()
.Get<CompareResult>(Arg.Is<Uri>(u => u.ToString() == "repos/owner/repo/compare/base...head"), null);
.Get<CompareResult>(Arg.Is<Uri>(u => u.ToString() == "repos/owner/repo/compare/base...head"));
}
[Fact]
@@ -654,7 +654,7 @@ namespace Octokit.Tests.Clients
client.Compare("owner", "repo", "base", "shiftkey/my-cool-branch");
connection.Received()
.Get<CompareResult>(Arg.Is<Uri>(u => u.ToString() == "repos/owner/repo/compare/base...shiftkey%2Fmy-cool-branch"), null);
.Get<CompareResult>(Arg.Is<Uri>(u => u.ToString() == "repos/owner/repo/compare/base...shiftkey%2Fmy-cool-branch"));
}
}
@@ -684,7 +684,7 @@ namespace Octokit.Tests.Clients
client.Get("owner", "name", "reference");
connection.Received()
.Get<GitHubCommit>(Arg.Is<Uri>(u => u.ToString() == "repos/owner/name/commits/reference"), null);
.Get<GitHubCommit>(Arg.Is<Uri>(u => u.ToString() == "repos/owner/name/commits/reference"));
}
}

3
Octokit.Tests/Clients/RepositoryCommentsClientTests.cs
View File

@@ -20,8 +20,7 @@ public class RepositoryCommentsClientTests
client.Get("fake", "repo", 42);
connection.Received().Get<CommitComment>(Arg.Is<Uri>(u => u.ToString() == "repos/fake/repo/comments/42"),
null);
connection.Received().Get<CommitComment>(Arg.Is<Uri>(u => u.ToString() == "repos/fake/repo/comments/42"));
}
[Fact]

3
Octokit.Tests/Clients/RepositoryDeployKeysClientTests.cs
View File

@@ -30,8 +30,7 @@ namespace Octokit.Tests.Clients
deployKeysClient.Get("user", "repo", 42);
apiConnection.Received().Get<DeployKey>(Arg.Is<Uri>(u => u.ToString() == "repos/user/repo/keys/42"),
null);
apiConnection.Received().Get<DeployKey>(Arg.Is<Uri>(u => u.ToString() == "repos/user/repo/keys/42"));
}
[Fact]

2
Octokit.Tests/Clients/RepositoryHooksClientTest.cs
View File

@@ -41,7 +41,7 @@ namespace Octokit.Tests.Clients
client.Hooks.Get("fake", "repo", 12345678);
connection.Received().Get<RepositoryHook>(Arg.Is<Uri>(u => u.ToString() == "repos/fake/repo/hooks/12345678"), null);
connection.Received().Get<RepositoryHook>(Arg.Is<Uri>(u => u.ToString() == "repos/fake/repo/hooks/12345678"));
}
[Fact]

2
Octokit.Tests/Clients/TagsClientTests.cs
View File

@@ -17,7 +17,7 @@ public class TagsClientTests
client.Get("owner", "repo", "reference");
connection.Received().Get<GitTag>(Arg.Is<Uri>(u => u.ToString() == "repos/owner/repo/git/tags/reference"), null);
connection.Received().Get<GitTag>(Arg.Is<Uri>(u => u.ToString() == "repos/owner/repo/git/tags/reference"));
}
[Fact]

2
Octokit.Tests/Clients/TeamsClientTests.cs
View File

@@ -32,7 +32,7 @@ namespace Octokit.Tests.Clients
client.Get(1);
connection.Received().Get<Team>(Arg.Is<Uri>(u => u.ToString() == "teams/1"), null);
connection.Received().Get<Team>(Arg.Is<Uri>(u => u.ToString() == "teams/1"));
}
}

6
Octokit.Tests/Clients/TreesClientTests.cs
View File

@@ -21,8 +21,7 @@ namespace Octokit.Tests
client.Get("fake", "repo", "123456ABCD");
connection.Received().Get<TreeResponse>(Arg.Is<Uri>(u => u.ToString() == "repos/fake/repo/git/trees/123456ABCD"),
null);
connection.Received().Get<TreeResponse>(Arg.Is<Uri>(u => u.ToString() == "repos/fake/repo/git/trees/123456ABCD"));
}
[Fact]
@@ -49,8 +48,7 @@ namespace Octokit.Tests
client.GetRecursive("fake", "repo", "123456ABCD");
connection.Received().Get<TreeResponse>(Arg.Is<Uri>(u => u.ToString() == "repos/fake/repo/git/trees/123456ABCD?recursive=1"),
null);
connection.Received().Get<TreeResponse>(Arg.Is<Uri>(u => u.ToString() == "repos/fake/repo/git/trees/123456ABCD?recursive=1"));
}
[Fact]

16
Octokit/Helpers/ApiExtensions.cs
View File

@@ -13,22 +13,6 @@ namespace Octokit
/// </summary>
public static class ApiExtensions
{
/// <summary>
/// Gets the API resource at the specified URI.
/// </summary>
/// <typeparam name="T">Type of the API resource to get.</typeparam>
/// <param name="connection">The connection to use</param>
/// <param name="uri">URI of the API resource to get</param>
/// <returns>The API resource.</returns>
/// <exception cref="ApiException">Thrown when an API error occurs.</exception>
public static Task<T> Get<T>(this IApiConnection connection, Uri uri)
{
Ensure.ArgumentNotNull(connection, "connection");
Ensure.ArgumentNotNull(uri, "uri");
return connection.Get<T>(uri, null);
}
/// <summary>
/// Gets all API resources in the list at the specified URI.
/// </summary>

14
Octokit/Http/ApiConnection.cs
View File

@@ -43,6 +43,20 @@ namespace Octokit
/// </summary>
public IConnection Connection { get; private set; }
/// <summary>
/// Gets the API resource at the specified URI.
/// </summary>
/// <typeparam name="T">Type of the API resource to get.</typeparam>
/// <param name="uri">URI of the API resource to get</param>
/// <returns>The API resource.</returns>
/// <exception cref="ApiException">Thrown when an API error occurs.</exception>
public Task<T> Get<T>(Uri uri)
{
Ensure.ArgumentNotNull(uri, "uri");
return Get<T>(uri, null);
}
/// <summary>
/// Gets the API resource at the specified URI.
/// </summary>

10
Octokit/Http/IApiConnection.cs
View File

@@ -18,6 +18,16 @@ namespace Octokit
/// </summary>
IConnection Connection { get; }
/// <summary>
/// Gets the API resource at the specified URI.
/// </summary>
/// <typeparam name="T">Type of the API resource to get.</typeparam>
/// <param name="uri">URI of the API resource to get</param>
/// <returns>The API resource.</returns>
/// <exception cref="ApiException">Thrown when an API error occurs.</exception>
[SuppressMessage("Microsoft.Naming", "CA1716:IdentifiersShouldNotMatchKeywords", MessageId = "Get")]
Task<T> Get<T>(Uri uri);
/// <summary>
/// Gets the API resource at the specified URI.
/// </summary>