zoriya/octokit.net
1
0
Fork 0
mirror of https://github.com/zoriya/octokit.net.git synced 2026-06-01 18:35:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

Change the GetAll methode signature in the ICommitStatusClient interface

Browse Source
This commit is contained in:
Abdelkhalek Oussama Elhamer
2016-03-23 19:04:16 +01:00
parent a988ad166a
commit 5f306cfdcc
3 changed files with 10 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Octokit.Tests/Clients/CommitStatusClientTests.cs
+1 -1
View File
@@ -35,7 +35,7 @@ namespace Octokit.Tests.Clients
StartPage = 1
};
client.GetAll("fake", "repo",options, "sha");
client.GetAll("fake", "repo", "sha", options);
connection.Received()
.GetAll<CommitStatus>(Arg.Is<Uri>(u => u.ToString() == "repos/fake/repo/commits/sha/statuses"));
Octokit/Clients/CommitStatusClient.cs
+6 -6
View File
@@ -36,7 +36,7 @@ namespace Octokit
Ensure.ArgumentNotNullOrEmptyString(name, "name");
Ensure.ArgumentNotNullOrEmptyString(reference, "reference");
return GetAll(owner,name,ApiOptions.None,reference);
return GetAll(owner,name,reference,ApiOptions.None);
}
/// <summary>
@@ -47,16 +47,16 @@ namespace Octokit
/// https://developer.github.com/v3/repos/statuses/#list-statuses-for-a-specific-ref
/// </remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="options">Options for changing the API response</param>
/// <param name="name">The name of the repository</param>
/// <param name="reference">The reference (SHA, branch name, or tag name) to list commits for</param>
/// <param name="options">Options for changing the API response</param>
/// <returns></returns>
public Task<IReadOnlyList<CommitStatus>> GetAll(string owner, string name, ApiOptions options, string reference)
public Task<IReadOnlyList<CommitStatus>> GetAll(string owner, string name, string reference, ApiOptions options)
{
Ensure.ArgumentNotNullOrEmptyString(owner, "owner");
Ensure.ArgumentNotNullOrEmptyString(name, "name");
Ensure.ArgumentNotNull(options, "options");
Ensure.ArgumentNotNullOrEmptyString(name, "name");
Ensure.ArgumentNotNullOrEmptyString(reference, "reference");
Ensure.ArgumentNotNull(options, "options");
return ApiConnection.GetAll<CommitStatus>(ApiUrls.CommitStatuses(owner, name, reference),options);
}
Octokit/Clients/ICommitStatusClient.cs
+3 -3
View File
@@ -32,11 +32,11 @@ namespace Octokit
/// https://developer.github.com/v3/repos/statuses/#list-statuses-for-a-specific-ref
/// </remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="options">Options for changing the API response</param>
/// <param name="name">The name of the repository</param>
/// <param name="reference">The reference (SHA, branch name, or tag name) to list commits for</param>
/// <param name="options">Options for changing the API response</param>
/// <returns></returns>
Task<IReadOnlyList<CommitStatus>> GetAll(string owner, string name, ApiOptions options, string reference);
Task<IReadOnlyList<CommitStatus>> GetAll(string owner, string name, string reference, ApiOptions options);
/// <summary>
/// Retrieves a combined view of statuses for the specified reference. A reference can be a commit SHA, a branch name, or