zoriya/octokit.net
1
0
Fork 0
mirror of https://github.com/zoriya/octokit.net.git synced 2026-06-07 04:16:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

Renamed GetAll with sub-namespace to GetAllForSubNamespace and added test for the regular GetAll

Browse Source
This commit is contained in:
Kristian Hellang
2013-11-25 16:14:04 +01:00
parent e5009598f7
commit 786c7e50f3
3 changed files with 32 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Octokit.Tests/Clients/ReferencesClientTests.cs
+30 -5
View File
@@ -54,10 +54,10 @@ namespace Octokit.Tests.Clients
{
var client = new ReferencesClient(Substitute.For<IApiConnection>());
await AssertEx.Throws<ArgumentNullException>(async () => await client.GetAll(null, "name", "heads"));
await AssertEx.Throws<ArgumentNullException>(async () => await client.GetAll("owner", null, "heads"));
await AssertEx.Throws<ArgumentException>(async () => await client.GetAll("", "name", "heads"));
await AssertEx.Throws<ArgumentException>(async () => await client.GetAll("owner", "", "heads"));
await AssertEx.Throws<ArgumentNullException>(async () => await client.GetAll(null, "name"));
await AssertEx.Throws<ArgumentNullException>(async () => await client.GetAll("owner", null));
await AssertEx.Throws<ArgumentException>(async () => await client.GetAll("", "name"));
await AssertEx.Throws<ArgumentException>(async () => await client.GetAll("owner", ""));
}
[Fact]
@@ -66,7 +66,32 @@ namespace Octokit.Tests.Clients
var connection = Substitute.For<IApiConnection>();
var client = new ReferencesClient(connection);
await client.GetAll("owner", "repo", "heads");
await client.GetAll("owner", "repo");
connection.Received().GetAll<Reference>(Arg.Is<Uri>(u => u.ToString() == "repos/owner/repo/git/refs"));
}
}
public class TheGetAllForSubNamespaceMethod
{
[Fact]
public async Task EnsuresNonNullArguments()
{
var client = new ReferencesClient(Substitute.For<IApiConnection>());
await AssertEx.Throws<ArgumentNullException>(async () => await client.GetAllForSubNamespace(null, "name", "heads"));
await AssertEx.Throws<ArgumentNullException>(async () => await client.GetAllForSubNamespace("owner", null, "heads"));
await AssertEx.Throws<ArgumentException>(async () => await client.GetAllForSubNamespace("", "name", "heads"));
await AssertEx.Throws<ArgumentException>(async () => await client.GetAllForSubNamespace("owner", "", "heads"));
}
[Fact]
public async Task RequestsCorrectUrl()
{
var connection = Substitute.For<IApiConnection>();
var client = new ReferencesClient(connection);
await client.GetAllForSubNamespace("owner", "repo", "heads");
connection.Received().GetAll<Reference>(Arg.Is<Uri>(u => u.ToString() == "repos/owner/repo/git/refs/heads"));
}
Octokit/Clients/IReferencesClient.cs
+1 -1
View File
@@ -41,7 +41,7 @@ namespace Octokit
/// <param name="name">The name of the repository</param>
/// <param name="subNamespace">The sub-namespace to get references for</param>
/// <returns></returns>
Task<IReadOnlyList<Reference>> GetAll(string owner, string name, string subNamespace);
Task<IReadOnlyList<Reference>> GetAllForSubNamespace(string owner, string name, string subNamespace);
/// <summary>
/// Creates a reference for a given repository
Octokit/Clients/ReferencesClient.cs
+1 -1
View File
@@ -56,7 +56,7 @@ namespace Octokit
/// <param name="name">The name of the repository</param>
/// <param name="subNamespace">The sub-namespace to get references for</param>
/// <returns></returns>
public Task<IReadOnlyList<Reference>> GetAll(string owner, string name, string subNamespace)
public Task<IReadOnlyList<Reference>> GetAllForSubNamespace(string owner, string name, string subNamespace)
{
Ensure.ArgumentNotNullOrEmptyString(owner, "owner");
Ensure.ArgumentNotNullOrEmptyString(name, "name");