Updated the response classes so that they pass the convention tests and code analysis.

This commit is contained in:
Kristian Hald
2015-03-14 16:41:30 +01:00
parent 7abdcf9240
commit f559690164
7 changed files with 44 additions and 17 deletions
+27 -11
View File
@@ -2,23 +2,39 @@
using System.Collections.Generic;
using System.Diagnostics;
using System.Globalization;
using System.Linq;
using System.Text;
using System.Threading.Tasks;
namespace Octokit
{
[DebuggerDisplay("{DebuggerDisplay,nq}")]
public class RepositoryHook
{
public string Url { get; set; }
public DateTimeOffset CreatedAt { get; set; }
public DateTimeOffset UpdatedAt { get; set; }
public string Name { get; set; }
public IEnumerable<string> Events { get; set; }
public bool Active { get; set; }
public dynamic Config { get; set; }
public int Id { get; set; }
public RepositoryHook(int id, string url, DateTimeOffset createdAt, DateTimeOffset updatedAt, string name, IEnumerable<string> events, bool active, RepositoryHookConfiguration config)
{
Url = url;
CreatedAt = createdAt;
UpdatedAt = updatedAt;
Name = name;
Events = events;
Active = active;
Config = config;
Id = id;
}
public int Id { get; private set; }
public string Url { get; private set; }
public DateTimeOffset CreatedAt { get; private set; }
public DateTimeOffset UpdatedAt { get; private set; }
public string Name { get; private set; }
public IEnumerable<string> Events { get; private set; }
public bool Active { get; private set; }
public RepositoryHookConfiguration Config { get; private set; }
internal string DebuggerDisplay
{
@@ -7,8 +7,15 @@ namespace Octokit
[DebuggerDisplay("{DebuggerDisplay,nq}")]
public class RepositoryHookConfiguration
{
public string Url { get; set; }
public string ContentType { get; set; }
public RepositoryHookConfiguration(string contentType, string url)
{
ContentType = contentType;
Url = url;
}
public string Url { get; private set; }
public string ContentType { get; private set; }
internal string DebuggerDisplay
{
+1
View File
@@ -387,6 +387,7 @@
<Compile Include="Models\Response\PublicKey.cs" />
<Compile Include="Models\Request\ReleaseAssetUpload.cs" />
<Compile Include="Models\Request\RepositoryRequest.cs" />
<Compile Include="Models\Response\RepositoryHookConfiguration.cs" />
</ItemGroup>
<Import Project="$(MSBuildBinPath)\Microsoft.CSharp.targets" />
</Project>
+3 -2
View File
@@ -102,7 +102,7 @@
<Compile Include="Models\Request\RequestParameters.cs" />
<Compile Include="Models\Response\Commit.cs" />
<Compile Include="Models\Response\Activity.cs" />
<Compile Include="Models\Response\ActivityPayloads\ActivityPayload.cs" />
<Compile Include="Models\Response\ActivityPayloads\ActivityPayload.cs" />
<Compile Include="Models\Response\ActivityPayloads\CommitCommentPayload.cs" />
<Compile Include="Models\Response\ActivityPayloads\ForkEventPayload.cs" />
<Compile Include="Models\Response\ActivityPayloads\IssueCommentPayload.cs" />
@@ -399,6 +399,7 @@
<Compile Include="Models\Response\AccountType.cs" />
<Compile Include="Models\Request\ReleaseAssetUpload.cs" />
<Compile Include="Models\Request\RepositoryRequest.cs" />
<Compile Include="Models\Response\RepositoryHookConfiguration.cs" />
</ItemGroup>
<Import Project="$(MSBuildExtensionsPath)\Novell\Novell.MonoDroid.CSharp.targets" />
</Project>
</Project>
+2 -1
View File
@@ -99,7 +99,7 @@
<Compile Include="Models\Request\RequestParameters.cs" />
<Compile Include="Models\Response\Commit.cs" />
<Compile Include="Models\Response\Activity.cs" />
<Compile Include="Models\Response\ActivityPayloads\ActivityPayload.cs" />
<Compile Include="Models\Response\ActivityPayloads\ActivityPayload.cs" />
<Compile Include="Models\Response\ActivityPayloads\CommitCommentPayload.cs" />
<Compile Include="Models\Response\ActivityPayloads\ForkEventPayload.cs" />
<Compile Include="Models\Response\ActivityPayloads\IssueCommentPayload.cs" />
@@ -392,6 +392,7 @@
<Compile Include="Models\Response\AccountType.cs" />
<Compile Include="Models\Request\ReleaseAssetUpload.cs" />
<Compile Include="Models\Request\RepositoryRequest.cs" />
<Compile Include="Models\Response\RepositoryHookConfiguration.cs" />
</ItemGroup>
<Import Project="$(MSBuildExtensionsPath)\Xamarin\iOS\Xamarin.MonoTouch.CSharp.targets" />
<Import Project="$(MSBuildBinPath)\Microsoft.CSharp.targets" />
+1 -1
View File
@@ -269,7 +269,6 @@
<Compile Include="Models\Response\ReleaseAsset.cs" />
<Compile Include="Models\Response\Repository.cs" />
<Compile Include="Models\Response\RepositoryHook.cs" />
<Compile Include="Models\Response\RepositoryHookConfiguration.cs" />
<Compile Include="Models\Response\SearchRepositoryResult.cs" />
<Compile Include="Models\Response\SshKey.cs" />
<Compile Include="Models\Response\SshKeyInfo.cs" />
@@ -386,6 +385,7 @@
<Compile Include="Models\Request\GistFileUpdate.cs" />
<Compile Include="Models\Request\ReleaseAssetUpload.cs" />
<Compile Include="Models\Request\RepositoryRequest.cs" />
<Compile Include="Models\Response\RepositoryHookConfiguration.cs" />
</ItemGroup>
<ItemGroup>
<CodeAnalysisDictionary Include="..\CustomDictionary.xml">
+1
View File
@@ -112,6 +112,7 @@
<Compile Include="Models\Response\RepositoryContent.cs" />
<Compile Include="Models\Response\RepositoryContentChangeSet.cs" />
<Compile Include="Models\Response\RepositoryContributor.cs" />
<Compile Include="Models\Response\RepositoryHookConfiguration.cs" />
<Compile Include="Models\Response\RepositoryPermissions.cs" />
<Compile Include="Models\Request\NewThreadSubscription.cs" />
<Compile Include="Models\Response\DeployKey.cs" />